fix: correct code link for alias by eryue0220 · Pull Request #2056 · npmx-dev/npmx.dev

eryue0220 · 2026-03-13T04:06:58Z

🔗 Linked issue

resolve #2044

🧭 Context

support alias path like ~/app/components/Button.vue, @/app/components/Button.vue or #/app/components/Button.vue

📚 Description

vercel · 2026-03-13T04:07:03Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ready	Preview, Comment	Mar 17, 2026 2:27am
npmx.dev	Ready	Preview, Comment	Mar 17, 2026 2:27am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
npmx-lunaria	Ignored		Mar 17, 2026 2:27am

codecov · 2026-03-13T04:24:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

…ix/issue-2044 * 'fix/issue-2044' of github.com:eryue0220/npmx.dev: fix: align weekly chart buckets from end to match npm downloads (npmx-dev#2052)

coderabbitai · 2026-03-13T08:46:24Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds internal alias import resolution across the codebase. Introduces new types and exports in server/utils/import-resolver.ts (InternalImportTarget, InternalImportsMap, resolveAliasToDir, resolveInternalImport, helpers) and extends createImportResolver to accept an optional internal imports map. Updates server/api/registry/file/[...pkg].get.ts to include imports?: InternalImportsMap on PackageJson and to pass it into the resolver. Modifies server/utils/code-highlight.ts to short‑circuit specifiers starting with #, ~ or @/ to the relative resolver. Adds unit tests for internal import resolution.

Suggested reviewers

danielroe
graphieros

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description clearly references resolving issue `#2044` and provides context about supporting alias paths like ~/app/components/Button.vue and `@/app/components/Button.vue`.
Linked Issues check	✅ Passed	The changes implement alias path support (`#2044`) by adding internal import resolution, updating the PackageJson interface with imports property, extending code-highlight logic for alias prefixes, and providing comprehensive test coverage.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to resolving issue `#2044`: adding alias path support to the import resolver, updating the PackageJson interface, extending code-highlight logic, and testing the new functionality.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

test/unit/server/utils/import-resolver.spec.ts (1)

194-299: Great test expansion; add one #/ canonicalisation regression case.

Please add a case where the specifier is #/app/... but the imports key is #app, to lock the slash-variant behaviour.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 42e2b622-9ae9-4d7c-b79d-c8d2478854a5

📥 Commits

Reviewing files that changed from the base of the PR and between 8976969 and 5099d3b.

📒 Files selected for processing (4)

server/api/registry/file/[...pkg].get.ts
server/utils/code-highlight.ts
server/utils/import-resolver.ts
test/unit/server/utils/import-resolver.spec.ts

server/utils/code-highlight.ts

server/utils/import-resolver.ts

coderabbitai

🧹 Nitpick comments (1)

server/utils/import-resolver.ts (1)
264-269: Minor performance optimisation: move normalisation outside the loop.

normalizeAliasPrefix(specifier) is computed on every iteration but the result never changes. Consider hoisting it before the loop.
♻️ Suggested refactor
 function guessInternalImportTarget(
   imports: InternalImportsMap,
   specifier: string,
   files: FileSet,
   currentFile: string,
 ): string | null {
+  const normalizedSpecifier = normalizeAliasPrefix(specifier)
   for (const [key, value] of Object.entries(imports)) {
-    const normalizedSpecifier = normalizeAliasPrefix(specifier)
     const normalizedKey = normalizeAliasPrefix(key)

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bda51135-cf70-4e3f-90aa-3fd46fb1d0a8

📥 Commits

Reviewing files that changed from the base of the PR and between cfdc81f and a6ad3f9.

📒 Files selected for processing (2)

server/api/registry/file/[...pkg].get.ts
server/utils/import-resolver.ts

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

server/utils/import-resolver.ts (1)

258-316: Refactor guessInternalImportTarget into smaller helpers.

This method currently handles matching, suffix derivation, probing, and return shaping in one block, which makes it harder to maintain and test safely.

As per coding guidelines, "Keep functions focused and manageable (generally under 50 lines)".

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2c7399fb-e4e1-44c9-8cf8-a21c19a00fba

📥 Commits

Reviewing files that changed from the base of the PR and between a6ad3f9 and 8c29a0e.

📒 Files selected for processing (1)

server/utils/import-resolver.ts

server/utils/import-resolver.ts

…ix/issue-2044 * 'fix/issue-2044' of github.com:eryue0220/npmx.dev: chore(deps): update dependency std-env to v4 (npmx-dev#2095)

eryue0220 added 2 commits March 13, 2026 10:24

wip

c25cafc

fix issues

83503cc

vercel bot deployed to Preview – npmx.dev March 13, 2026 04:09 View deployment

Merge branch 'main' into fix/issue-2044

12ee36d

vercel bot deployed to Preview – npmx.dev March 13, 2026 08:01 View deployment

add test cases

9ac82cc

vercel bot deployed to Preview – npmx.dev March 13, 2026 08:36 View deployment

Merge branch 'main' into fix/issue-2044

5099d3b

eryue0220 marked this pull request as ready for review March 13, 2026 08:38

vercel bot deployed to Preview – npmx.dev March 13, 2026 08:40 View deployment

eryue0220 added 2 commits March 13, 2026 16:44

remove test code

e6a8d16

Merge branch 'fix/issue-2044' of github.com:eryue0220/npmx.dev into f…

a2859c1

…ix/issue-2044 * 'fix/issue-2044' of github.com:eryue0220/npmx.dev: fix: align weekly chart buckets from end to match npm downloads (npmx-dev#2052)

coderabbitai bot reviewed Mar 13, 2026

View reviewed changes

server/utils/code-highlight.ts Outdated Show resolved Hide resolved

server/utils/import-resolver.ts Show resolved Hide resolved

add alias case

cfdc81f

vercel bot deployed to Preview – npmx.dev March 13, 2026 08:48 View deployment

serhalp added the needs review This PR is waiting for a review from a maintainer label Mar 15, 2026

vercel bot deployed to Preview – npmx.dev March 16, 2026 07:26 View deployment

eryue0220 added 2 commits March 16, 2026 15:26

fix cr

91bfb34

Merge branch 'main' into fix/issue-2044

a6ad3f9

vercel bot deployed to Preview – npmx.dev March 16, 2026 07:30 View deployment

coderabbitai bot reviewed Mar 16, 2026

View reviewed changes

fix cr

8c29a0e

vercel bot deployed to Preview – npmx.dev March 16, 2026 08:31 View deployment

coderabbitai bot reviewed Mar 16, 2026

View reviewed changes

server/utils/import-resolver.ts Show resolved Hide resolved

server/utils/import-resolver.ts Show resolved Hide resolved

Merge branch 'main' into fix/issue-2044

dd546ee

vercel bot deployed to Preview – docs.npmx.dev March 16, 2026 10:07 View deployment

vercel bot deployed to Preview – npmx.dev March 16, 2026 10:07 View deployment

eryue0220 added 3 commits March 17, 2026 10:23

cr

80a2e1c

Merge branch 'fix/issue-2044' of github.com:eryue0220/npmx.dev into f…

b2508a3

…ix/issue-2044 * 'fix/issue-2044' of github.com:eryue0220/npmx.dev: chore(deps): update dependency std-env to v4 (npmx-dev#2095)

Merge branch 'main' into fix/issue-2044

74cd4f5

vercel bot deployed to Preview – docs.npmx.dev March 17, 2026 02:27 View deployment

vercel bot deployed to Preview – npmx.dev March 17, 2026 02:27 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: correct code link for alias#2056

fix: correct code link for alias#2056
eryue0220 wants to merge 15 commits intonpmx-dev:mainfrom
eryue0220:fix/issue-2044

eryue0220 commented Mar 13, 2026

Uh oh!

vercel bot commented Mar 13, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 13, 2026

Uh oh!

coderabbitai bot commented Mar 13, 2026 •

edited

Loading

Reviews paused

Walkthrough

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

eryue0220 commented Mar 13, 2026

🔗 Linked issue

🧭 Context

📚 Description

Uh oh!

vercel bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 13, 2026

Codecov Report

Uh oh!

coderabbitai bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Mar 13, 2026 •

edited

Loading

coderabbitai bot commented Mar 13, 2026 •

edited

Loading